Skip to content

feat: updates the user instructions re OAuth #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 25, 2023
Merged

feat: updates the user instructions re OAuth #603

merged 5 commits into from
Jan 25, 2023

Conversation

chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented Jan 20, 2023 •
edited by parthea
Loading

Provides user instructions as part of the pandas-gbg documentation to support authentication using OAuth for highly constrained development environments.

BEGIN_COMMIT_OVERRIDE
docs: updates the user instructions re OAuth
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 20, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jan 20, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Jan 20, 2023
tswast
tswast reviewed Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM, but I think this might be better on a separate page so that we don't overwhelm folks for whom the default flow works fine.

@chalmerlowe
Copy link
Collaborator Author

@tswast

Content LGTM, but I think this might be better on a separate page so that we don't overwhelm folks for whom the default flow works fine.

Good point. I separated out the content into two pages. I added cross references within each document to help ensure that users are guided to the appropriate content.

@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 23, 2023
@chalmerlowe chalmerlowe marked this pull request as ready for review January 25, 2023 17:46
@chalmerlowe chalmerlowe requested a review from a team as a code owner January 25, 2023 17:46
@chalmerlowe chalmerlowe requested review from a team and yirutang January 25, 2023 17:46
@chalmerlowe chalmerlowe merged commit 0c2b716 into main Jan 25, 2023
@chalmerlowe chalmerlowe deleted the end-user-instructions branch January 25, 2023 17:46
@release-please release-please bot mentioned this pull request Jan 25, 2023
Merged
@parthea parthea added the release-please:force-run To run release-please label Jan 25, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@yirutang yirutang Awaiting requested review from yirutang

Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalmerlowe @tswast @parthea